Wikipedia:Bots/Requests for approval/RonBot 14
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was
Approved.
Operator: Ronhjones (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)
Time filed: 20:29, Wednesday, November 14, 2018 (UTC)
Function overview: Upscales the nominal size of an non free SVG (but not exceeding NFC guideline) post a manual request.
Automatic, Supervised, or Manual: Automatic
Programming language(s): Python
Source code available: Based on RonBot4 - User:RonBot/4/Source1 (used to change the nominal size of oversized NFC svg files, so the resultant png files are below NFC guideline), will change to use a different category as input, to be set by a new template.
Links to relevant discussions (where appropriate): (Copied from my Talk Page)...Hi Ron, I had an idea for new functionality in RonBot. Your bot already fixes images that are too large to meet the NFC guidelines, but another frequent problem with SVG files is that they'll be too small. What often happens is, someone will extract a logo from a PDF where it appeared very small, and as a result, their SVG will have a tiny nominal size. Someone reading an article will click on the logo, expecting to see it bigger, and instead they'll see a much smaller version of it. An example of this right now is the logo on Charlotte Independence (used to affect maybe half of the teams in that league, but I've manually fixed most of them).
Would you consider developing new functionality for RonBot to raise SVGs to the maximum allowed resolution for NFC? Obviously, you wouldn't want to automatically scale up every SVG, since some are presumably intended to be so small. Instead, an editor would have to manually tag the image to be upsized. The current process of manually fixing this is quite tedious, so being able to simply click a button in Twinkle and add a template would make it much easier to eradicate these unnecessarily-tiny logos. Let me know what you think of my idea. Thanks, IagoQnsi (talk) 19:13, 14 November 2018 (UTC)
Edit period(s): Daily
Estimated number of pages affected: Low number of images, just those that are tagged manually
Namespace(s): Files
Exclusion compliant (Yes/No): Yes
Function details: Based on a manually added template (with an associated category), the bot will just adjust the width and height parameters in the "<svg" tag of the image, to allow the size to of the resultant png to be more readable, but of course below the NFC guideline.
Discussion
[edit]With all due respect, is this *really* necessary, given that MediaWiki already allows SVGs to be scaled arbitrarily? -FASTILY 01:37, 15 November 2018 (UTC)
- Well the requester thought it would be useful, and since there is virtually zero coding to do, I did not see an issue. It does stop items such as File:Gun Owners of America Logo.svg looking rather silly. Ronhjones (Talk) 21:59, 15 November 2018 (UTC)
- Ronhjones, Is there anything in place to keep the bot from edit warring with a human editor? Looking at the example you mention here, the bot would re-size the SVG again, after it's already resized once, albeit from a different task. I would note that in this case - that's a good thing! I could see this irritating some editors, however. SQLQuery me! 09:52, 20 November 2018 (UTC)
- SQL I doubt if there is anyone who really wants a smaller SVG - but we could add a check if necessary (examine page history for the edit summary used to upscale the image). The example shown, for some reason the author wanted a whole lot of white space above and to the right of the logo. Looking at it now, it might well be a vandal edit - it makes the article page look weird - I'm going to revert it anyway - editor seems to have vanished. Ronhjones (Talk) 15:40, 20 November 2018 (UTC)
- Ronhjones, Is there anything in place to keep the bot from edit warring with a human editor? Looking at the example you mention here, the bot would re-size the SVG again, after it's already resized once, albeit from a different task. I would note that in this case - that's a good thing! I could see this irritating some editors, however. SQLQuery me! 09:52, 20 November 2018 (UTC)
I can see there is a need for this sort of functionality, but I'm not convinced that bot is the best way provide it. Have you considered rolling this into a web application and putting it on toolforge? -FASTILY 02:29, 28 November 2018 (UTC)
- No idea how to do that, my bots only run from my PC. We are only talking about a small number of manually tagged files. The code to edit the svg is going to be the same as RonBot 4, just upscales rather than downscales. Ronhjones (Talk) 21:53, 28 November 2018 (UTC)
Approved for trial (25 edits or 14 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Primefac (talk) 21:41, 16 December 2018 (UTC)
Trial complete. Files changed are listed at User:RonBot/14/Trial. I picked some of those as possible potential move to commons as {{PD-textlogo}}, so better to see a bigger image to check if move is possible. Bot changed the size as expected, no surprise as it's exactly the same code as RonBot4, with the "Pixel<105000" check removed. Ronhjones (Talk) 20:43, 4 January 2019 (UTC)
- Approved. — xaosflux Talk 16:21, 7 January 2019 (UTC)
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.